calimero-network / core

Calimero 2.0
https://calimero-network.github.io/
Other
58 stars 8 forks source link

fix: stack size VM limits #961

Closed miraclx closed 1 week ago

miraclx commented 1 week ago

630 unintentionally swapped the values for max_storage_pages and max_stack_size.

Losing semantic information was a bad idea, and constructor functions for structs with all fields public are non-beneficial. Functions with many arguments, also a bad idea.

This seemingly subtle change led to a stack overflow on an intel machine, but not on M1 Pro for some reason, worth investigating later. As it's part of why it wasn't caught earlier.