search

callstack / repack

A Webpack-based toolkit to build your React Native application with full support of Webpack ecosystem.
https://re-pack.dev
MIT License
1.49k stars 110 forks source link

fix: query object been encoded again on iOS side #739

Closed ra1nj closed 2 months ago

ra1nj commented 2 months ago

Summary

The query object return by ScriptManager's resolver will be encoded in Script.from(). But on iOS side, the query will be encoded again. This pr will fix this behavior.

Test plan

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 876a1ede7e276225d09a7e7031bca7237c0bc177

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ---------------------------- | ----- | | @callstack/repack | Patch | | @callstack/repack-dev-server | Patch | | @callstack/repack-init | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **repack-website** | ⬜️ Ignored ([Inspect](https://vercel.com/callstack-team/repack-website/HUyq8hZvx5xNrph79Fn92Be2ynWx)) | [Visit Preview](https://repack-website-git-fork-ra1nj-fix-url-enc-8710be-callstack-team.vercel.app) | | Sep 12, 2024 6:23am |
ra1nj commented 2 months ago

Hi @jbroma , thank you for your kindly advices, it's really helpful and i gained new knowledges! Also i created another pull request for handling the download failed situation on iOS, i checked this on Android, i think it's already implemented there : if (response.isSuccessful)

jbroma commented 2 months ago

verified working on iOS, thanks for your contribution 🎉