search

callumrollo / glidertest

Diagnostic test of glider data quality and required processing
MIT License
0 stars 4 forks source link

Plotting updates #128

Closed eleanorfrajka closed 1 week ago

eleanorfrajka commented 1 week ago

Ok - I fiddled around a little to change the aspect ratio in plots (main change). There may be a more elegant way to do this, but it was because the mplstyle only has one figure size option. I would like a way to have full width and half width plots or otherwise a little more overall control on the figure size generated.

Hence - two more variables at the top of plots.py for the widths, and a couple figures where I then used the width to generate within the figure plot) an appropriate height of the figure.

Also a couple label changes.

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

eleanorfrajka commented 1 week ago

Oh no - thought I could be clever and push a suggested reordering of demo.ipynb, but I forgot that since it's in the same branch, it would show up in this pull request...

MOchiara commented 1 week ago

Why are we not changing the figure size in the glidertest mplstyle file and then add a haf/full True and False statement in the plot function instead?

MOchiara commented 1 week ago

Tests are failing because you changed some labels in the plot and you have 'assert' in the test_plots referring to the old labels