search

callumrollo / glidertest

Diagnostic test of glider data quality and required processing
MIT License
0 stars 4 forks source link

[FEAT] Added checks and plots based on oxygen SOP #139

Closed MOchiara closed 1 day ago

review-notebook-app[bot] commented 3 days ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

MOchiara commented 3 days ago

Currently the spike function is the least efficient thing ever produced so any suggestions are more than welcome

callumrollo commented 3 days ago

I think this might be a case where it is best to use existing libraries rather than reinventing the wheel. In this case, I would recommend looking at ioos_qc which implements the QARTOD toolbox including global range, spike test and stuck values.

I wrote an example notebook with some glider data for it https://github.com/ioos/ioos_qc/blob/main/docs/source/examples/QartodTestExample_Glider.ipynb

MOchiara commented 3 days ago

Uhh fair point! I will check it now and implement it, thanks for the suggestion!

callumrollo commented 3 days ago

It might be something to discuss with later today, OG1 support a standardised approach to QC, so we could have a function called pretty early on that runs QC on the whole dataset, then we can just pass that dataset with QC vars to various plotting functions

MOchiara commented 3 days ago

Yeah sure, it is a great discussion point! We can chat about this later

MOchiara commented 1 day ago
image