calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.46k stars 235 forks source link

Google Drive Userscript Doesn't Work In Brave Browser #837

Closed mikedesu closed 4 years ago

mikedesu commented 4 years ago

I've got Tampermonkey installed. Videos and setup works in Chrome loading videos from Google Drive, but I get the error in Brave:

"The media could not be loaded, either because the server or network failed or because the format is not supported"

Tried x265 and x264 vids, no luck.

calzoneman commented 4 years ago

Hi,

Firstly, have you checked whether it is a Brave specific issue? Google Drive requires 3rd party cookies and sometimes doesn't work for other reasons as well (certain people have said that it doesn't work unless they log in, certain extensions break it, etc.). You can see some documentation about the 3rd party cookie issue and common extensions which cause problems here: https://github.com/calzoneman/sync/wiki/Google-Drive-Userscript-Installation-Guide#troubleshooting (the instructions talk about Chrome or Firefox, but the principles should be the same for other browsers, just a different options menu).

If there is a problem with the userscript specific to Brave, if someone would like to debug it and provide a patch, feel free to do so, however I'm currently not interested in maintaining the userscript (for any browser).

I generally recommend to avoid Google Drive since it relies on undocumented APIs which have failure modes outside of my control, and which require users to disable privacy protection features in order for it to work. I would love to delete it; the only reason it still exists in the codebase is because enough people still use it -- if it breaks in a way that would require effort to fix it for existing browsers that work, I would remove the feature instead.

mikedesu commented 4 years ago

Genius. Fixed!

That said, if I hosted videos in a place other than Google Drive, it'd still work fine I imagine, the convenience is just kind of really nice for my use-case right now...plus I can now use it with Brave! Thank you!

--advertisement removed--

On Thu, Nov 14, 2019 at 8:18 PM Calvin Montgomery notifications@github.com wrote:

Hi,

Firstly, have you checked whether it is a Brave specific issue? Google Drive requires 3rd party cookies and sometimes doesn't work for other reasons as well (certain people have said that it doesn't work unless they log in, certain extensions break it, etc.). You can see some documentation about the 3rd party cookie issue and common extensions which cause problems here: https://github.com/calzoneman/sync/wiki/Google-Drive-Userscript-Installation-Guide#troubleshooting (the instructions talk about Chrome or Firefox, but the principles should be the same for other browsers, just a different options menu).

If there is a problem with the userscript specific to Brave, if someone would like to debug it and provide a patch, feel free to do so, however I'm currently not interested in maintaining the userscript (for any browser).

I generally recommend to avoid Google Drive since it relies on undocumented APIs which have failure modes outside of my control, and which require users to disable privacy protection features in order for it to work. I would love to delete it; the only reason it still exists in the codebase is because enough people still use it -- if it breaks in a way that would require effort to fix it for existing browsers that work, I would remove the feature instead.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/calzoneman/sync/issues/837?email_source=notifications&email_token=AABILA4UDDEH3J42U53A3RLQTX2HTA5CNFSM4JNQJ3M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEED6GKA#issuecomment-554165032, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABILAZREAWO3AEW74QBRBDQTX2HTANCNFSM4JNQJ3MQ .