Create Gherkin tests for device-status-reachability and device-status-roaming

camaraproject / DeviceStatus

Repository to describe, develop, document and test the Device Status API family

Apache License 2.0

11 stars 33 forks source link

Create Gherkin tests for device-status-reachability and device-status-roaming #186

Closed mdomale closed 3 months ago

mdomale commented 4 months ago

Feature file for device-reachability-status & device-roaming-status

What type of PR is this?

tests

What this PR does / why we need it:

Gherkin syntax feature file for syntax

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

bigludo7 commented 4 months ago

Hello @mdomale Thanks for the contribution. Probably better to split in 2 files to have one file for device-reachability-status and another for device-connectivity-status.

On the file itself we should align with the API-Testing-Guidelines. We should have environment variables, background section, etc... You can probably take a look on this PR that could be used as an illustration of the guidelines.

mdomale commented 4 months ago

Updated as per newly agreed camara testing guidelines

bigludo7 commented 3 months ago

@mdomale @akoshunyadi It looks very good for me.

For me oly one thing missing: all explicit error are not tested. You have added 422 DEVICE_IDENTIFIERS_MISMATCH. We should also add test cased for 422 DEVICE_NOT_APPLICABLE, 422 UNABLE_TO_PROVIDE_REACHABILITY_STATUS and 422 UNSUPPORTED_DEVICE_IDENTIFIERS

Then for me we will be good ! Thanks

mdomale commented 3 months ago

@bigludo7 @sachinvodafone PR amended. Kindly review

mdomale commented 3 months ago

@bigludo7 @bigludo7 PR updated .