cambrian / accumulator

Cryptographic accumulators in Rust.
https://cambrian.github.io/accumulator
MIT License
133 stars 34 forks source link

Class bench #14

Closed mstraka100 closed 5 years ago

mstraka100 commented 5 years ago

Benchmarks for class groups

whaatt commented 5 years ago

just curious, what is the purpose of the bench_x functions? (as opposed to calling .reduce() and .normalize() directly)

mstraka100 commented 5 years ago

just curious, what is the purpose of the bench_x functions? (as opposed to calling .reduce() and .normalize() directly)

.reduce() and .normalize() should be private to ClassElem, and our benchmarks exist in a separate crate so they can't be accessed. Making public functions that compile conditionally lets them be accessed for benchmarking only

Open to cleaner solutions but couldn't think of any