search

cambrian / accumulator

Cryptographic accumulators in Rust.
https://cambrian.github.io/accumulator
MIT License
133 stars 34 forks source link

Reduce class group tests should perform reduction #17

Closed mstraka100 closed 5 years ago

mstraka100 commented 5 years ago

Currently the test_reduce_basic function in src/group/class.rs reduces an element that becomes reduced after performing normalization. This causes the main while loop in reduce to remain untested. An element that remains unreduced after being normalized should be chosen instead.

alanefl commented 5 years ago

Fixed in upcoming class-groups PR.

alanefl commented 5 years ago

For the record, we ensure that this element is not reduced after being normalized:

"591622449216197258120089391432207181572679374270745984479112414101314701592477848522107674496756100372887295518141911986241641798660763521874054424965681889882724221330887550366991453623858407722364030436647784154711966786382417857735305311987204975806227417098805337249042201223588540680465532198634196097774987618046254796507721237545238070019766545882259089280223674368",
      "1876035109500483975519353216485660565059030662716924896410088429565283890582815894123373861317582184925374832910231950495841019095282022050357011392057654267692865921180759019994102795819589538544637244426188502280065345420910149796358880981957270357948408527891335462137136228534113829969158795324927018842939341713211084125981312294562651547786576689605628072971047864713",
      "1487227089143280305479117572769463109575596494335839441131411078340457771410217037970036525659967904949382486274280359007946171269114609839747084089656003433231585822182110307677690712327731511663233738510120405523289136140542863597204059620545031674701208079483869128054789412824674160108875508735923455414134698083729234232028811139717522029609862989010845930564341935336"