camelot-project / frontend

The frontend: The web-facing server software for CAMELOT
BSD 3-Clause "New" or "Revised" License
2 stars 14 forks source link

Units and other parameters from table units and metadata (when available) #140

Closed ltesti closed 9 years ago

ltesti commented 9 years ago

Recoded following the suggestion from Adam. This has been tested with ipac tables. Should fill in the units and metadata that are found in the table (the user will still need to review and submit and/or fill in for missing units/metadata). Example:

\DOI = "10.1051/0004-6361/201014177"
\ADS = "2010A&A...520A..50S"
\author = GinaSantangelo
\email = ltesti@eso.org
\IsObserved = True
\IsGalactic = True
|  ID | Radius | SurfaceDensity | VelocityDispersion |
|char | float  | float          | float              |
|     |  pc    |  g/cm^2        |  km/s              |
   co1   3.0      0.10            7.3                 
   co2   4.1      0.08            5.5                 
   co3   8.3      0.08            5.2                 
...
keflavich commented 9 years ago

Looks good. BTW, what I meant about the docs was to add a description here: http://camelot-project.herokuapp.com/upload_form

This issue is related: https://github.com/camelot-project/frontend/issues/116

ltesti commented 9 years ago

I have added some text to the upload_form.html and one example. The example is not rendered as I would have liked (I am not good enough at html, I guess): the example file is not aligned as in my original file, which is what I wanted. This should take care also of issue https://github.com/camelot-project/frontend/issues/116

keflavich commented 9 years ago

@ltesti - could you attach a screenshot? Maybe I can help with the HTML.

On some browsers, you can capture the area into your copy buffer (ctrl-alt-shift-4) then paste directly into the comment box in github.

ltesti commented 9 years ago

@keflavich this is what I see on the browser: screen shot 2015-06-21 at 21 19 18

...but I would really like to see it as it appears in the first comment on this page...

keflavich commented 9 years ago

OK, I can help with that. Besides this cosmetic change, are you satisfied (is it ready to merge)?

ltesti commented 9 years ago

I think it is...

bcommerc commented 9 years ago

Thanks a lot for this, it is now very clear, and sorry for my latency...