search

camicroscope / SlideLoader

Tool for loading slide metadata for caMicroscope
BSD 3-Clause "New" or "Revised" License
3 stars 19 forks source link

Create uploading dir if not exist #37

Closed birm closed 1 year ago

birm commented 4 years ago

This being missing causes the service to stay up but fail to work properly with no hint. @nanli-emory has inspired this

GrayFlash commented 3 years ago

@birm Is the issue still un-resolved??

Also, I wish to make if I got the issue clearly, so you want changes in upload.sh file. Where the /images/ folder needs to be created if it does not exist?? Or should one make these changes in upload.py file and check if the folder passed in the arguments exists or not?

birm commented 3 years ago

This is about SlideServer.py, which expects a directory called uploading for temporarily holding files before they're fully finished uploading. See https://github.com/camicroscope/SlideLoader/blob/5c05199bbc3424436186e1e2557fc0a21de3d987/SlideServer.py#L40 This task would just be to add this directory should it not exist.

GrayFlash commented 3 years ago

@birm I made a pr for this, will be great if you could review it and raise any necessary concerns.

YashKumarVerma commented 3 years ago

This issue can be closed now.