camicroscope / caMicroscope

Digital pathology image viewer with support for human/machine generated annotations and markups.
BSD 3-Clause "New" or "Revised" License
255 stars 295 forks source link

[BUG] Unexpected Placeholder and Field Value in Sign Up Page #472

Closed sohamsshah closed 1 year ago

sohamsshah commented 3 years ago

Describe the bug When the user goes to Sign Up page, one can see fields in the Sign Up form. One of them has a placeholder - ['list','of','filters']. I am unsure that is this a feature to be built or something is breaking behind.

To Reproduce Steps to reproduce the behavior:

  1. Go to landing page
  2. Click on MORE under caMicroscope.
  3. Sign Up via Google Email ID. (Dont open in Incognito. It wont work)
  4. Click on Sign Up on the Navbar (inspite of you being already signed up via Google 🤔)
  5. See Error.

Expected behavior The fields must be well defined for users to use. [Also can you please provide more insights required on the sign up flow (references to resources to read would be do or brief explanation)]

Screenshots ss_2

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Would love to work on this issue. But quite interested to know more about:

Thank you.

birm commented 3 years ago

We could absolutely use a better input for this. This is just for a list of arbitrary strings to match slides for access-limiting. note that ["**"] (an entry as two asterisks) lets the user see all slides.

We could probably also rethink access management better than this, this filter system (tag based access control) is more of a quick-fix.

Eddges commented 3 years ago

I would like to work on this. I checked the code and this '[list, of, filters]' is explicitly declared as the placeholder text for the input. I'm not sure what it means.

@birm can you help me understand what it means so I can hopefully find a more intuitive way?

birm commented 3 years ago

I'll explain, but it certainly needs a revamp, since it's confusing far more people than it's helping :)

We started work on an attribute-based access control, that is giving users access to only some slides. So, if a slide has "a" and "b" as its filters, a user can only see that slide's metadata if they have at least one of "a" or "b" in their list of filters.

The current access control is more-or-less a proof of concept, and I'm absolutely open to alternate proposals.

Eddges commented 3 years ago

So I have come up with two possible solutions based on the availability of these filters.

Case 1: These filters are predefined, and there are only a handful of them

Meta Available

Case 2: These filters are of not predefined, and the user can add their own filters, in which case even if there are a handful of filters initially, their number might grow quickly

Meta Not Available

@birm please let me know if I totally got your point wrong, or if you would like to proceed with these suggestions. Thanks :-)

birm commented 3 years ago

I'd make it clearer what "slide preferences" are, but otherwise I really like the idea. :)

Priyaraj17 commented 3 years ago

Hey @birm , is it open? May I work on it?

birm commented 1 year ago

Closing as a stale issue. Feel free to reopen if you think this should be active still.