search

canada-ca / OS-Advisory_Conseil-SO

Open Source Advisory Board - Conseil consultatif du logiciel libre
Apache License 2.0
38 stars 26 forks source link

Build fixup #80

Closed nschonni closed 5 years ago

nschonni commented 6 years ago

Not sure if https://events.drupal.org/nashville2018 is just responding slowly for the remaining error

gcharest commented 6 years ago

Could very well be. I've been having issues with builds not passing tests due to slow response time. But then actually using the links in the browser works just fine.

Le ven. 9 nov. 2018 20 h 06, Nick Schonning notifications@github.com a écrit :

Not sure if https://events.drupal.org/nashville2018 is just responding slowly for the remaining error

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/canada-ca/OS-Advisory_Conseil-SO/pull/80#issuecomment-437542879, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnJ5Yv1l2dxIXMqTKl4tc2YpTq6Fwj-ks5utiaVgaJpZM4YXvGn .

--

Guillaume

nschonni commented 6 years ago

Restarted the build and the Drupal links are happy again

gcharest commented 6 years ago

As long as they are happy ;)

Thanks!

Le dim. 11 nov. 2018 à 21:36, Nick Schonning notifications@github.com a écrit :

Restarted the build and the Drupal links are happy again

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/canada-ca/OS-Advisory_Conseil-SO/pull/80#issuecomment-437734109, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnJ5ZBz8y99oiS0BhtErHZTZj3yeDMTks5uuN63gaJpZM4YXvGn .

--

Guillaume

nschonni commented 6 years ago

@gcharest this should be good to merge now

gcharest commented 6 years ago

Thanks!

Le mer. 21 nov. 2018 15 h 20, Nick Schonning notifications@github.com a écrit :

@gcharest https://github.com/gcharest this should be good to merge now

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/canada-ca/OS-Advisory_Conseil-SO/pull/80#issuecomment-440797213, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnJ5ap7B_n3072eU7bWfy3Wk0xyzeMOks5uxbVygaJpZM4YXvGn .

--

Guillaume

nschonni commented 5 years ago

Rebased with latest minutes. After this lands, it probably would help to turn on pull requests for the master branch

gcharest commented 5 years ago

I thought they were? The only protection I have enabled is up-to-date and CI.

Ping me if there's something else you'd like to change.

Thanks!

nschonni commented 5 years ago

@gcharest you probably need to enable "Can't edit the protected branch or upload files to it from the web" https://help.github.com/articles/about-protected-branches/#branch-protection-settings and use PRs to make changes

gcharest commented 5 years ago

Will check, thanks!