search

canada-ca / cloud-guardrails-gcp

Recommended configuration guidance for Google Cloud Platform / Conseils de configuration recommandés pour Platforme infonuagique de Google
Other
22 stars 14 forks source link

Downloading resource json step incorrect #2

Closed kevin-shelaga closed 3 years ago

kevin-shelaga commented 3 years ago

The following step downloads a file name "cai-dir" without a .json file extension and as a result run.sh cannot find the file. https://github.com/canada-ca/cloud-guardrails-gcp/blob/main/guardrails-validation/README.md

gsutil cp gs://$MY_BUCKET_NAME/resource_inventory.json ./cai-dir

Should be updated to

gsutil cp gs://$MY_BUCKET_NAME/resource_inventory.json ./assets
kevin-shelaga commented 3 years ago

Fixed with https://github.com/canada-ca/cloud-guardrails-gcp/pull/6