caneco / laravel-country-logomarks

The unofficial (but blessed) Laravel Country Logomarks
Other
122 stars 15 forks source link

Wales #10

Open JustSteveKing opened 3 years ago

JustSteveKing commented 3 years ago

Is you request a new country in the list? Not yet!

Your country community links We only have a general PHP community currently (which I organise) but we are full of Laravel Devs!

Additional context We have a dragon on our flag, so feel we represent early Laravel very well

caneco commented 3 years ago

Here's a preview 🏴󠁧󠁒󠁷󠁬󠁳󠁿

image




But to be honest…

I don't know how to place the assets folder πŸ€” Should I place it:

From the 3 options I'm considering either B) or C)…

JustSteveKing commented 3 years ago

It mainly depends on the convention you are following, from what I can see you are following country codes in an ISO format, I would recommend "CY" as this is the typical language code for Welsh.

https://en.m.wikipedia.org/wiki/Welsh_language

caneco commented 3 years ago

@JustSteveKing I'm trying to keep the ISO 3166-1 ALPHA-2 … but TBH I now see that failed big time with the UK Logomark πŸ˜…

With that in mind, CY should be Cyprus πŸ€”

JustSteveKing commented 3 years ago

Damn, these things are tricky! Either way, you're doing an awesome job!

You could look at ISO_3166-2 which are country short codes - but then you still hit the UK issue.

Perhaps stick with the pattern you are already following and then: area-country such as uk-cy for Wales and uk-ire for Northern Ireland? Do it which ever way works for you πŸ˜„

caneco commented 3 years ago

@JustSteveKing I'm planing to move the UK folder to GB and use the name "Great Britain" instead of "UK".

Can I have your comments on the PR #27?

– Thanks

JustSteveKing commented 3 years ago

That makes perfect sense to me @caneco and I've added a comment on the PR for you. But to log it here also:

I think moving UK to GB makes a lot of sense as it leave you open to expand further should you need to. Also it's a common standard being used, which as someone who loves standards can 100% appreciate!

Thanks for your awesome work as always!

caneco commented 3 years ago

(late response; sorry)

@JustSteveKing thanks for the feedback and validation of the decision πŸ‘

JustSteveKing commented 3 years ago

No problems @caneco anytime!

JustSteveKing commented 3 years ago

@caneco did this one ever get merged?