canonical / canonical.com

Repository for the new version of canonical.com
Other
33 stars 66 forks source link

Build /solutions/ai + modal #1222

Closed mtruj013 closed 6 months ago

mtruj013 commented 6 months ago

Needs pdm approval before merging

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-9435

webteam-app commented 6 months ago

Demo starting at https://canonical-com-1222.demos.haus

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.14%. Comparing base (24efb31) to head (e30b9c6). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1222 +/- ## ========================================== - Coverage 71.45% 66.14% -5.31% ========================================== Files 12 10 -2 Lines 1023 898 -125 ========================================== - Hits 731 594 -137 - Misses 292 304 +12 ``` | [Flag](https://app.codecov.io/gh/canonical/canonical.com/pull/1222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/canonical.com/pull/1222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `66.14% <ø> (-5.31%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

juanruitina commented 6 months ago
Screenshot 2024-03-20 at 10 46 12

And a suggestion: I'd left align the logos under "Run on any cloud" on small and medium viewports; they look weird right-aligned when they wrap.

mtruj013 commented 6 months ago

@juanruitina could you take another look?

juanruitina commented 6 months ago

LGTM!

bartaz commented 6 months ago

Country field is not marked as required, but seems to be required:

image

Same about company, and others

image image image

Also if required fields are marked with there should be a footnote somewhere, explaining that means required field.

bartaz commented 6 months ago

How do I enter country code if I can type just numbers?

image
mtruj013 commented 6 months ago

How do I enter country code if I can type just numbers?

Honestly, I'm not sure where this request came from, but we've been adding it to quite a few forms on c.com. I agree though, it doesn't make much sense and it's also not in any form doc that I could find so I removed