search

canonical / charm-relation-interfaces

https://canonical.github.io/charm-relation-interfaces/
Apache License 2.0
16 stars 49 forks source link

[DPE-5484] Add TLS flag + TLS CA fields #185

Closed lucasgameiroborges closed 1 week ago

lucasgameiroborges commented 1 month ago

Adds a tls flag to indicate wether TLS is being used on the provider's side + tls-ca field for the CA chain of certificates.

See corresponding implementation PR here: https://github.com/canonical/postgresql-k8s-operator/pull/719

tonyandrewmeyer commented 1 month ago

Hi - is there background somewhere on why the postgresql_client interface has manually crafted JSON rather than a schema.py that auto-generates the JSON?

marceloneppel commented 1 month ago

Hi - is there background somewhere on why the postgresql_client interface has manually crafted JSON rather than a schema.py that auto-generates the JSON?

Hi, @tonyandrewmeyer! I believe it's because the postgresql_client and the other Data Platform interfaces were created in either 2022 or early 2023. I see that maybe the first PR that used schema.py to auto-generate the JSON was introduced in March 2023.

lucasgameiroborges commented 3 weeks ago

Hi there - Not sure who to ping to get a review here? @tonyandrewmeyer or maybe @PietroPasotti ?

tonyandrewmeyer commented 2 weeks ago

Hi, @tonyandrewmeyer! I believe it's because the postgresql_client and the other Data Platform interfaces were created in either 2022 or early 2023. I see that maybe the first PR that used schema.py to auto-generate the JSON was introduced in March 2023.

Ok, thanks. I think we'll want to have all the interfaces defined the same way (manual schema.py, automated JSON) eventually, but I guess it doesn't have to be done now.