canonical / charmed-kubeflow-workflows

Repository that containes GitHub workflows and shareable configs for Charmed Kubeflow
0 stars 0 forks source link

ROCKs CI convention: single-rock repositories should include a subfolder for their rock #52

Open orfeas-k opened 5 months ago

orfeas-k commented 5 months ago

The way ROCKs CI is designed right now implies that it doesn't work (as it should) for single-rock repository structure where the rockcraft.yaml file is placed in the repo's parent directory (example).

How ROCKs CI works

This means that it will trigger the workflow and rebuild the rock for changes to any file in the repo.

Solution

Since during discussions with the team, we agreed that we prefer single-rock repositories to include a subfolder for their rock (example), then we can:

  1. Take this convention into consideration when creating spec for the CI #48
  2. Document that this is how it works explicitly #47
  3. Restructure any rock repository not following the agreed structure.
syncronize-issues-to-jira[bot] commented 5 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5495.

This message was autogenerated