fix(rust_plugin): fix dependency validation logic

canonical / craft-parts

https://canonical-craft-parts.readthedocs-hosted.com

GNU Lesser General Public License v3.0

11 stars 37 forks source link

fix(rust_plugin): fix dependency validation logic #903

Open liushuyu opened 4 days ago

liushuyu commented 4 days ago

[X] Have you signed the CLA?

This pull request fixes the dependency validation logic regarding the "rust-deps" situation. If rustup is installed, then cargo and rustc will return an error code of 1 instead of 127 if no default toolchain is installed (because cargo and rustc will be shims generated by rustup).

Two more tests are added to verify this new validation logic.

Should fix #890.

liushuyu commented 17 hours ago

Do I need to rebase the changes for this pull request to merge cleanly?