search

canonical / craft-providers

Python interfaces for instantiating and executing builds for a variety of target environments.
https://canonical-craft-providers.readthedocs-hosted.com/en/latest/
GNU Lesser General Public License v3.0
6 stars 22 forks source link

Get Pro status in managed LXD instance #652

Closed linostar closed 2 months ago

linostar commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/pro-sources@5a98385). Learn more about missing BASE report.

Files with missing lines Patch % Lines
craft_providers/lxd/lxc.py 88.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/pro-sources #652 +/- ## ====================================================== Coverage ? 98.88% ====================================================== Files ? 54 Lines ? 4478 Branches ? 0 ====================================================== Hits ? 4428 Misses ? 50 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

linostar commented 2 months ago

@canonical/starcraft-reviewers This is ready.

linostar commented 2 months ago

Could you add integration tests to this that check it with, say, Ubuntu Noble and Alma Linux 9?

@lengau We don't have spread tests in craft-providers. Perhaps we can do such tests in rockcraft once all those pro PRs are merged?

lengau commented 2 months ago

@linostar I'm requesting an integration test like the ones here: https://github.com/canonical/craft-providers/blob/main/tests/integration/lxd/test_lxc.py

It would create an instance and run these functions on that instance.