canonical / design.ubuntu.com

7 stars 29 forks source link

Add email signature to design resources #311

Closed bartaz closed 6 months ago

bartaz commented 6 months ago

Done

Adds email signature to design resources.

Drive-by: update slide template preview

Fixes WD-9907 Fixes WD-4140

QA

Screenshots

image
webteam-app commented 6 months ago

Demo starting at https://design-ubuntu-com-311.demos.haus

lyubomir-popov commented 6 months ago

@bartaz the implementation looks good, thanks. I need to check with camille why the tag seems taller in the sig than the logos above. I'll get back to you once I receive an answer. ALso can we please use the latest sldie template?

This one is old: image

Here's an updated thumbnail: Canonical Slides Template

gerwitz commented 6 months ago

FWIW I tested using this to copy-paste the signature and it worked well 👍

camillet16 commented 6 months ago

@bartaz Here's the fixed logo at x2 to accommodate retina screens.

20 YEARS_logo_white-bg

Notes:

CC: @lyubomir-popov

gerwitz commented 6 months ago

@bartaz it looks like the logos element ID got re-used, here. Not a big deal because I was able to target #email-signature-frame.

bartaz commented 6 months ago

@bartaz it looks like the logos element ID got re-used, here. Not a big deal because I was able to target #email-signature-frame.

Good catch @gerwitz, should be fixed now: https://design.ubuntu.com/resources#email-signature

gerwitz commented 5 months ago

Next challenge unlocked! Does anyone have any idea why the iframe is editable? https://discourse.canonical.com/t/new-email-signature/3459/2

bartaz commented 5 months ago

Next challenge unlocked! Does anyone have any idea why Stephanie sees the iframe as editable? https://discourse.canonical.com/t/new-email-signature/3459/2

@gerwitz Because it is editable. I made it editable as it felt like a nice feature, so you could edit it in place and copy/paste. If that causes confusion it's easy to revert.

gerwitz commented 5 months ago

I missed that somehow despite even searching the source for contenteditable 😮‍💨

I think it is confusing, since we haven't suggested editing-in-place and the image being draggable makes selecting finicky. Let's "freeze" it.

And if you're modifying anyway, maybe we can add instructions below:

Use this template for email signatures. See Discourse for Gmail instructions

bartaz commented 5 months ago

I think it is confusing, since we haven't suggested editing-in-place and the image being draggable makes selecting finicky. Let's "freeze" it.

Yes, I can see that it makes dragging the image too easy. Will update.