search

canonical / docs.conjure-up.io

Documentation for Conjure-up
Other
2 stars 17 forks source link

New homepage + update documentation-builder to 1.6.0 #42

Closed Caleb-Ellis closed 6 years ago

Caleb-Ellis commented 6 years ago

Done

QA

Screenshot

0 0 0 0_8204_devel_en_ 1

webteam-app commented 6 years ago

Starting demo at: http://conjure-up-docs-pr-42.run.demo.haus/

Caleb-Ellis commented 6 years ago

So the new base template is working on the demo server, but not the new homepage. I think it has something to do with how documentation-builder builds versions based on git branches. Anyway I'm going to play around with it a bit and see if I can get it to work properly, but in the meantime the demo shows everything as it would be without the new homepage (of which you can see a screenshot).

adam-stokes commented 6 years ago

Looks really awesome! There is one minor thing i noticed:

screenshot-conjure-up-docs-pr-42 run demo haus-2018 06 21-10-00-35

Looks like it's listed twice in the navigation panel

Caleb-Ellis commented 6 years ago

@battlemidget That's actually an issue in the live version of the devel branch (https://docs.conjure-up.io/devel/en/). I think I'm going to need some help from @WillMoggridge or @nottrobin to get my changes showing up on the demo server :(

adam-stokes commented 6 years ago

@Caleb-Ellis ah! ok lemme look at my docs

adam-stokes commented 6 years ago

getting anxious for this to go live :)

webteam-app commented 6 years ago

Starting demo at: http://conjure-up-docs-pr-42.run.demo.haus/

Caleb-Ellis commented 6 years ago

@battlemidget Hey sorry, I've been away for a bit! Anyway, with a little bit of hacking around I've got the demo server showing the changes, basically by removing the "build version branches" flag and creating the demo from that. So you can't change versions in the demo, but the actual code in the PR will allow it. If you prefer I can split this out into two PRs like with the Juju and MAAS docs?

adam-stokes commented 6 years ago

Hey @Caleb-Ellis whatever makes sense, I don't have any preference.

Thanks!

Caleb-Ellis commented 6 years ago

Ok in that case I'll leave it as-is until someone is ready to review it :)

Caleb-Ellis commented 6 years ago

@evilnick Sounds good to me :) we've noted the issues from juju/docs#2847 and will hope to address them in the next doc-builder release (1.6.1)