search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.9k stars 219 forks source link

vfs: Weaken assertion to accomodate SQLITE_DIRECT_OVERFLOW_READ #564

Closed cole-miller closed 9 months ago

cole-miller commented 9 months ago

See here: https://github.com/sqlite/sqlite/blob/2aae3a95a97e38d82ec89d8b63ff5a9255b12225/src/btree.c#L5139-L5168

Signed-off-by: Cole Miller cole.miller@canonical.com

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3c400fd) 61.29% compared to head (ba246cc) 61.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #564 +/- ## ======================================= Coverage 61.29% 61.29% ======================================= Files 34 34 Lines 6834 6834 Branches 2031 2031 ======================================= Hits 4189 4189 Misses 1349 1349 Partials 1296 1296 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MathieuBordere commented 9 months ago

please test downstream

cole-miller commented 9 months ago

Incidentally the new VFS should be less vulnerable to this kind of thing since it forwards more of the I/O methods to the base VFS