search

canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.89k stars 218 forks source link

Fix the build when liblz4 is missing and test it #693

Closed cole-miller closed 2 months ago

cole-miller commented 2 months ago

The build was broken when --enable-build-raft was passed and liblz4 was missing due to a logic error in configure.ac. Fix this and test this particular build configuration in CI.

I only noticed this because we don't install liblz4-dev for the PPA builds and it's preventing setting --enable-build-raft there (canonical/dqlite-ppa#7).

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.88%. Comparing base (27eeeaf) to head (1dc45ba). Report is 71 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #693 +/- ## ========================================== - Coverage 77.97% 77.88% -0.10% ========================================== Files 197 197 Lines 28066 28007 -59 Branches 5544 5538 -6 ========================================== - Hits 21885 21812 -73 - Misses 4329 4349 +20 + Partials 1852 1846 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.