canonical / dqlite

Embeddable, replicated and fault-tolerant SQL engine.
https://dqlite.io
Other
3.89k stars 218 forks source link

Fix frames leak when VfsPoll fails #713

Closed cole-miller closed 1 month ago

cole-miller commented 1 month ago

VfsPoll can fail to acquire the WAL write lock, and the caller still needs to release the frames of the transaction in this case. Restores the behavior from before the exec_tick rewrite. Hat tip @marco6.

Signed-off-by: Cole Miller cole.miller@canonical.com

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (06992a6) to head (35a3242). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/leader.c 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #713 +/- ## ========================================== + Coverage 80.95% 81.02% +0.06% ========================================== Files 196 196 Lines 29186 29187 +1 Branches 4089 4091 +2 ========================================== + Hits 23627 23648 +21 + Misses 3895 3881 -14 + Partials 1664 1658 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.