[DPE-4956] Stabilise integration tests

canonical / kafka-operator

Kafka VM operator

Apache License 2.0

6 stars 14 forks source link

[DPE-4956] Stabilise integration tests #229

Closed Batalex closed 2 months ago

Batalex commented 3 months ago

See https://github.com/canonical/kafka-k8s-operator/pull/125 for the changelog

In addition, here are the additional fixes specific to VM:

Fixed jmx_prometheus jar path
Used workload.restart instead of start in balancer/start event handler. This is fine (and recommended) to use start on k8s because it does restart the service, whereas on VM we did not pick up the configuration changes

deusebio commented 2 months ago

I'm not really sure I can provide any sensible comment here. I'm happy for @marcoppenheimer and @zmraul to review this, given they have waaay more background and expertise on the code base / integration testing issues

If they don't have any, I'm clearly happy for this PR to be merged (also given that it consistently pass)