search

canonical / kafka-operator

Kafka VM operator
Apache License 2.0
6 stars 14 forks source link

[DPE-5702] chore: Active Controllers alert set to == 0 #252

Open marcoppenheimer opened 1 month ago

deusebio commented 1 month ago

I was syncing with @marcoppenheimer that has been discussing with @acsgn and my understanding is that the current PR should already fix the concerns or issue raised by ManSol.

@sbparke Could you confirm that https://github.com/canonical/zookeeper-operator/pull/166 and https://github.com/canonical/kafka-operator/pull/252 address your comments and that we can move forward with the merge, and finalize the release?

acsgn commented 1 month ago

LGTM! Interval changes would help with updating the views faster.

deusebio commented 1 month ago

I'm happy for these to be merged, also given that also ManSol provided their +1 and they don't have concern with this