Rewrite kubeflow-volumes-operator as sidecar - Githubissues

canonical / kubeflow-volumes-operator

Volumes Operator

Apache License 2.0

0 stars 3 forks source link

Rewrite kubeflow-volumes-operator as sidecar #125

Closed misohu closed 8 months ago

misohu commented 8 months ago

In this PR:

Rewrote the operator using BaseCharm sidecar pattern.
Rewrote unit tests to cover the new source code.
The kubeflow manifests for cluster roles are now part of this charm. Make sure to approve this PR for kubeflow-roles-operator as the manifests are no longer needed there (previously we were not able to deploy those with podspec charm).

Because there are no proper integration tests as mentioned in https://github.com/canonical/kubeflow-volumes-operator/issues/29, to test this PR I have deployed kubeflow-bundle 1.8 with this charm and I made sure I am able to

Create a new volume in the volumes UI.
I am able to use the newly created volume from inside the UI.
I am able to remove this volume from UI.

CI note: publish is failing because I renamed the resource in charm. Will publish new oci image when approved <3