canonical / mir-ci

Mir CI helpers
1 stars 1 forks source link

kvm: determine the correct x and y value space #115

Open Saviq opened 3 months ago

Saviq commented 3 months ago

https://github.com/canonical/mir-ci/blob/e92f83d92fab4e9916b8e198d3cce8a13fe95ad4/mir-ci/mir_ci/tests/robot/platforms/zapper/ZapperHid.py#L133-L134

I wonder if it should be a right-open interval instead. In a 100x100 output, I would expect the in-screen coordinates to be in the range of 0 to 99. OTOH, the current conversions from proportional to absolute coordinates assume that 0..1 is converted to 0..100.

_Originally posted by @hbatagelo in https://github.com/canonical/mir-ci/pull/112#discussion_r1538104003_