search

canonical / openstack-exporter-operator

The openstack-exporter-operator is a machine charm for openstack-exporter.
Apache License 2.0
1 stars 7 forks source link

cacert should be a file path and not a string on cloud.yaml #97

Closed gabrielcocenza closed 2 months ago

gabrielcocenza commented 3 months ago

Right now the cloud.yaml file is passing the cacert as a string which is not the standard way from the documentation

chanchiwai-ray commented 3 months ago

I suspect this indentation error, which I saw in openstack-exporter-k8s. The upstream documentation mentioned that it can be cacert string: https://github.com/openstack-exporter/openstack-exporter?tab=readme-ov-file#openstack-configuration

aieri commented 3 months ago

yes, but the idea here is that openstack-exporter should behave in the same way as any openstack client, which indeed it does, save for a small difference: the cacert option can either be a string or a path to a file (for the exporter), but it can only be a path for python-openstackclient. We think the charm should try to use the exporter in the most default way possible, meaning that the clouds.yaml file it renders should pass a path to the CA cert, not a string (even if either would work).