search

canonical / pc-gadget

The gadget snap for Personal Computers using 64bit Intel or AMD processors
GNU General Public License v3.0
31 stars 73 forks source link

gadget.yaml: add system-recovery partition #14

Closed mvo5 closed 5 years ago

mvo5 commented 5 years ago

For UC20 we want to have a recovery partition. This adds to the existing system-boot partition. The size is currently set to 600Mb - this is a bit arbitrary and will allow us roughtly 2 recovery systems. We have the following sizes today:

It also adds a initial grub.cfg which is very basic and only supports a single recovery system at this point but that recovery system can be selected via the grubenv:

Mostly a stub for now but it will allow us to start building a "pc" gadget in the "20/edge" channel.

mvo5 commented 5 years ago

This has not changed since a couple of days and we use it for our work to build images now. I would like to merge it into the 20 branch of the gadget and upload it to the "20/edge" channel for the "pc" snap in the store. But I need a :+1: review for this…

xnox commented 5 years ago

There are two branches in the repo one is called 20 the other is called uc20 can we just use one or the other? Or make server-side gitbranch reference link to make one point to the other? (not sure if github supports that).

vorlonofportland commented 5 years ago

There are two branches in the repo one is called 20 the other is called uc20 can we just use one or the other? Or make server-side gitbranch reference link to make one point to the other? (not sure if github supports that).

The uc20 branch is new, and appears to be a copy of 20. I guess this is based on the discussion about wanting consistent naming of uc20 branches across repos, and we should consider uc20 authoritative now? (Thus this PR will eventually need to be retargeted)

vorlonofportland commented 5 years ago

In fact, this PR appears to be superseded by https://github.com/snapcore/pc-amd64-gadget/pull/19.