canonical / solutions-engineering-automation

Repo for automating tasks for Solutions Engineering Team.
1 stars 5 forks source link

Fix issue with possibly wrong base branch for automated PRs #88

Closed samuelallan72 closed 1 month ago

samuelallan72 commented 1 month ago

see https://github.com/canonical/snap-tempest/pull/246 for example

samuelallan72 commented 1 month ago

I investigated this and I can't find anything to suggest it's using an incorrect base branch. It was working fine before https://github.com/canonical/solutions-engineering-automation/pull/74/files , but the only real thing that changed there was reusing the pr branch. So perhaps a bug in the github terraform provider that's mangling things when it reuses a branch? Or strange behaviour around adding commits to an existing branch?

EDIT: scratch that, I found the issue