search

canonical / test_observer

Flutter based dashboard for visualising SRU regression test results
3 stars 3 forks source link

Add artefact due date filters #190

Closed omar-selo closed 4 months ago

omar-selo commented 4 months ago

Description

Adds a new artefacts filter based on due date.

Resolved issues

Resolves https://warthogs.atlassian.net/browse/RTW-324

Documentation

I don't think we have any documentation on filters.

Web service API changes

None

Tests

See below video: Screencast from 2024-07-17 15-02-12.webm

jocave commented 4 months ago

Wow, really nice and clean implementation. I guess the background preparation we did for other filters helped us implement this one quite easily.

My only comment was about the "This week" option, as it is not really this week, but rather in a weeks time from now. So maybe we can rename the options to:

  • This week - In a week
  • Next week - In more than a week
  • Later than next week - In more than two weeks

Still, I'm not really sure what would be the best choice myself. Perhaps @jocave as a native-speaker should help us figure out the best wording for the choices.

within a week within two weeks more than two weeks

?

omar-selo commented 4 months ago

within a week within two weeks more than two weeks

Sounds clear and concise

Edit: Actually second one is inclusive of the first so it doesn't work.

omar-selo commented 4 months ago

I suggest we go with "Within a week" and "More than a week" and drop "More than two weeks" because I don't think we can actually see that at all. IIRC no artefacts will have more than two weeks deadline

andrejvelichkovski commented 4 months ago

I suggest we go with "Within a week" and "More than a week" and drop "More than two weeks" because I don't think we can actually see that at all. IIRC no artefacts will have more than two weeks deadline

Seems reasonable for now, we can follow-up if there are any concerns from others