canonical / test_observer

Flutter based dashboard for visualising SRU regression test results
3 stars 3 forks source link

Fix scroll resetting on rerun or review #203

Closed omar-selo closed 3 months ago

omar-selo commented 3 months ago

Description

On artefact page, when you scroll then rerun or review an environment, the scroll position resets to the top. After lots of debugging turns out that the issues occurs because initially the ArtefactPageBody widget builds a ListView. When you rerun or approve an artefact the ArtefactPageBody builds a YaruCircularProgressIndicator for a split second before building a ListView again. During this split second the older ListView is destroyed and together with it the scroll position on this page. To resolve the issue we avoid building a YaruCircularProgressIndicator during that split second. This can be done by using the filtered test executions provider's value property. This property will return the previous filtered test executions list while it's loading the changes of the rerun/review. Hence the ListView is always returned even when loading (at least not initially).

Resolved issues

https://warthogs.atlassian.net/browse/RTW-344

Documentation

None

Web service API changes

None

Tests

Screencast from 2024-08-08 13-36-46.webm Screencast from 2024-08-08 13-40-35.webm