Closed jmuzina closed 3 months ago
TBH I feel like this PR was opened a bit too soon. From the conversation on the issue it doesn't seem we had a decision to theme the colour, or what new value should be.
Currently the accent colour is not themed (has the same value in both themes). We could keep this funtionality, but add it to theme variables (both dark and light versions referencing the same $color-accent
value). Which could be a quick update to review (as it doesn't introduce any visual changes).
Now, we are opening the discussion in introducing a new colour for the dark theme, which may prolong the review.
Will close this but keep the branch around, and use it if/when the design decisions have been made
Color contrast is fine
Done
Themes the accent color by adding a new dark-theme accent color.
Fixes WD-11879
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots