canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
849 stars 169 forks source link

feat: Create amended pattern for 'equal-height-row' #5348

Closed petesfrench closed 2 months ago

petesfrench commented 2 months ago

This is a suggested pattern amendment for equal height row

This work came about as @mattea-turic suggested that the equal height row pattern did not look good on small/medium when you wanted to retain the image but there is not much text, see pr. It was suggested to retain the same stacked pattern that is used on large screens on medium and small screens.

I am looking for your thoughts on this. Should this exist as a custom variant on canonical.com? Could the variant be upstreamed (especially if it sees use in multiple places)?

The mock up for the pattern exists here: https://www.figma.com/design/uJUwbUAGDog4KCMivrMpnl/24.10-Data-Fabric?node-id=909-10435&node-type=FRAME&t=W6zUuA3DegagwprK-0

Done

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

Screenshots

Equal row height on medium screen without much text: image

Adjust pattern on medium screens: image

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

bartaz commented 2 months ago

I'm not sure exactly, but it looks similar to "wrap" variant we just released: https://vanillaframework.io/docs/patterns/equal-height-row#wrap-variant

@lyubomir-popov @pastelcyborg is this new proposal the same that we already added?

pastelcyborg commented 2 months ago

Yeah - as discussed on Mattermost, I believe we can close this PR. The wrap variant essentially provides the same functionality, with some minor differences, but also without modifying the root component, so the non-wrap variant is kept intact. The docs for Equal Height Row also contain examples of how to use our new responsive image container, which helps make images look optimal across all screen sizes.