Add legacy mode option to fix tooltip positioning issues (#398 and #760)

canton7 / SyncTrayzor

Windows tray utility / filesystem watcher / launcher for Syncthing

MIT License

5.97k stars 412 forks source link

Add legacy mode option to fix tooltip positioning issues (#398 and #760) #787

Open liuyd-dev opened 1 year ago

liuyd-dev commented 1 year ago

We have observed longstanding issues with tooltip positioning since 2017. Unfortunately a direct fix was not immediately feasible due to upstream dependencies.

This PR humbly proposes a "Show Tooltip in Legacy Mode" option as a workaround to issues #398 and #760. The goal is to use a different method to help address the positioning problems temporarily.

Extensive testing suggests this workaround is reliable without new bugs. While not a permanent solution, it may help alleviate the problem without significant changes for now.

The option remains experimental by nature. We hope to identify a better approach once dependencies allow. Any feedback would be appreciated to progress this effort.

Approval of this proposed change would be greatly valued in resolving a long-troubling user experience issue. We thank you for your consideration and understanding.

liuyd-dev commented 11 months ago

Hi @canton7 ,

I hope you're doing well. I submitted a PR (Number: #787) on SyncTrayzor and wanted to check in on its progress. It has been three months, and I was wondering if you have had a chance to review and address the PR?

If you need any additional information or further modifications, please let me know. I'm more than willing to collaborate to ensure that this PR is processed as soon as possible.

Thank you for your time and consideration. Looking forward to your response.

Best regards

The-Fireplace commented 7 months ago

@liuyd-dev Would you be willing to upload a build of this as a release on your fork?

liuyd-dev commented 7 months ago

@liuyd-dev Would you be willing to upload a build of this as a release on your fork?

I'm not able to conveniently build and release it, but you can refer to this link for building it.

Ryunam commented 2 months ago

I have compiled the modified x64 executable through Visual Studio 2019 with the changes implemented in this PR and I'm sharing the build output here for everyone's convenience. Please note: this is just the SyncTrayzor.exe file itself. You should first install the official release of the software as normal. Afterwards, go to the install folder and replace the existing SyncTrayzor.exe file with this version.

You can download the build here: SyncTrayzor (exe with legacy tooltip option).zip

After replacing the executable, start SyncTrayzor as normal, then go into File -> Settings and check this box:

You should now have the tooltip fully functional, without any top-left shifting. I have been testing this on a Windows 22H2 install, with multiple modifications applied on top of the default taskbar, and the tooltip is showing up and performing as expected.

Major credits go to @liuyd-dev for fixing this annoyance. Many thanks!