search

canton7 / fuelphp-casset

Better asset management library for fuelphp (with minification!)
MIT License
103 stars 29 forks source link

combine() does not include all group files #17

Closed gnodeb closed 12 years ago

gnodeb commented 12 years ago

If group contains file with defined minified version, that file will replace group content instead of appending it.

protected static function combine($type, $file_group, $minify, $inline) { ... if (static::$show_files_inline) $content .= PHP_EOL.'/* '.$file['file'].' */'.PHP_EOL.PHP_EOL; if ($file['minified'] || !$minify) $content = static::load_file($file['file'], $type, $file_group).PHP_EOL; ... }

last line should be: $content .= static::load_file($file['file'], $type, $file_group).PHP_EOL;

canton7 commented 12 years ago

Brilliant, thank you!

canton7 commented 12 years ago

I've pushed v1.14 with this fix