search

caozhichongchong / arg_ranker

MIT License
23 stars 11 forks source link

comparing arg-ranker v2 and v3 #8

Closed suskraem closed 2 years ago

suskraem commented 2 years ago

Hello, I re-ran the last two commands of my arg_ranker v2 run with arg_ranker v3 as instructed. However, when I compare the output files they are identical to the earlier version (including the total abundance). Are there any instances in which you would not expect any change? Where exactly should I be seeing a difference? I just want to make sure I'm reporting correct results! Thanks!

caozhichongchong commented 2 years ago

Hi,

Thank you for reaching out!

Did you run the last two commands with this new ARG_table.sum.py? This ARG_table.sum.py is meant for fixing arg_ranker.v2 and the results of arg_ranker.v2. Please do not replace ARG_table.sum.py in arg_ranker.v3 with this ARG_table.sum.py.

Please let me know if the new results are still the same. Hope it helps!

I have made it clearer in the README thanks to your question :)

Best regards, Anni