Determine optional action parameters from CSN's `notNull`

cap-js / cds-typer

CDS type generator for JavaScript

Apache License 2.0

29 stars 10 forks source link

Determine optional action parameters from CSN's `notNull` #332

Closed chgeo closed 2 months ago

chgeo commented 2 months ago

Replace the use of @Core.OptionalParameter for optional parameters (which was an intermediate solution anyways) by evaluating CSN's notNull property. This is in line with the decision in the CDS spec meeting and with what RFC importer now generates.

Note that this formally inverses the default for optional parameters:

They are all optional by default, which is how the runtime treats it.
Mandatory parameters now have to be marked with notNull (or not null in CDL).

daogrady commented 2 months ago

by evaluating CSN's notNull property.

Has this property been present all along or does it require a certain version of @sap/cds, the compiler, or any other related lib?

chgeo commented 2 months ago

Has this property been present all along or does it require a certain version of @sap/cds, the compiler, or any other related lib?

Has been there for a long time.