capawesome-team / capacitor-mlkit

⚡️ ML Kit plugins for Capacitor. Supports Android and iOS.
https://capawesome.io/plugins/mlkit/
Apache License 2.0
147 stars 46 forks source link

feat: add @capacitor-mlkit/face-mesh-detection package #78

Closed trancee closed 1 year ago

trancee commented 1 year ago

Pull request checklist

Please check if your PR fulfills the following requirements:

Just added the defintions, according to the Android reference. However, they might change again during implementation.

trancee commented 1 year ago

Looks good. Can you still fix the build and create a PR in https://github.com/robingenz/capacitor-mlkit-plugin-demo?

How do I fix the build since there is no iOS implementation? Any hints?

robingenz commented 1 year ago

@trancee I will take a look.

robingenz commented 1 year ago

@trancee Fixed! I forgot to set the correct node_modules path.

robingenz commented 1 year ago

@trancee Can we merge this?

trancee commented 1 year ago

@trancee Can we merge this?

Yes, I am done with the Android implementation.