search

capistrano / drupal-deploy

Gem for deploying Drupal projects with capistrano 3
MIT License
40 stars 26 forks source link

invoke the deploy flow in 'deploy:full' task #4

Closed gido closed 7 years ago

gido commented 9 years ago

Fix issue #3

gido commented 9 years ago

Hum, this is not a perfect solution because this implementation fire finished before the task is really finished. This mean that the current symlink is created before any drush command and so on...

I think that having two different tasks for deploying is not the capistrano way. What about checking if we need a updatedb or some features to revert and only in those cases execute the task and clear cache?

It's what capistrano-rails do for applying db migration. The other think is that you can include only some part of the whole recipes with require 'capistrano/rails/migrations' instruction.

gido commented 9 years ago

@gagarine What do you think about this PR and issue #3 ?

gagarine commented 9 years ago

EDIT (didn't read it right)

For the PR using invoke can lead to side effect apparently.

Conditionally clearing the cache can works. It will take a longer time but as long as the cache is not cleared if not needed it's ok. Would be useful to have a --no-cache-clear flag also to force it.