Upgrade to RN 0.47.2 - Githubissues

capitalone / react-native-pathjs-charts

Android and iOS charts based on react-native-svg and paths-js

Apache License 2.0

879 stars 261 forks source link

Closed Minishlink closed 7 years ago

Minishlink commented 7 years ago

Thank you for contributing a pull request.

Please ensure that you have signed the CLA.

This is backwards compatible.

Emilios1995 commented 7 years ago

the version upgrade of react-native-svg is important in order for this to run on android. Please merge .

marzolfb commented 7 years ago

@Minishlink Any chance you can test the change for ios? I ran into this problem: https://github.com/facebook/react-native/issues/14935.

This will need to be fixed before merging.

Minishlink commented 7 years ago

@marzolfb Are you talking about the Example app? It seems like the upgrade to 0.46 wasn't done with react-native-git-upgrade, I'll commit a fix.

marzolfb commented 7 years ago

Yes. Sorry for not being clear. Thanks for the additional commit.

Minishlink commented 7 years ago

Thanks!