search

caponica / AmazonMwsComplete

Name-spaced wrappers for the full set of Amazon MWS client libraries
56 stars 53 forks source link

Add reports for REPORT_FBA_SALES_ALL_BY_LAST_UPDATE_FLAT_FILE #24

Closed jasonhebert closed 6 years ago

jasonhebert commented 6 years ago

-- Add ReportFBASalesAllByLastUpdateFlatFile report and record

-- Add ReportFBASalesAllByLastUpdateFlatFile to BaseMwsReport

-- Refactor BaseMwsReport::convertReportTypeToReportClass()

caponica commented 6 years ago

I like what you did with the class map here. I'll get this merged in later, but I think we tend to use "Fba" instead of "FBA" in the camel case filenames, so I have updated that - see the changes in the fba_sales_by_last_update branch for details.

jasonhebert commented 6 years ago

Thanks and no worries. Is there a particular style guide you use?

There's also a couple of additional changes I'd like to make to that BaseMwsReport class to make it more friendly to extension. Currently you can't extend that class without including all of the methods in the child class, even if there's no change to them, because of the use of self::* instead of static::*. That change would allow a developer to extend that class and create their own reports if they are not included in the package.

I hope to have something for you possibly sometime today or tomorrow.