search

caponica / AmazonMwsComplete

Name-spaced wrappers for the full set of Amazon MWS client libraries
56 stars 53 forks source link

Bunch of improvements that I've added in the past 2 years #31

Closed maykino closed 4 years ago

jasonhebert commented 6 years ago

Modifying the files in the src/AmazonPhpClientLibrary directory, imho, shouldn't be done. These are library files provided by Amazon and in the event that these files are updated and incorporated here these changes will be overwritten.

caponica commented 6 years ago

Hi @maykino - I had a very quick look and there may be some gems in here, but you need to rebase your work to the current master before I can review and accept it.

maykino commented 6 years ago

Sure and sorry about the mess. I've been using it for my own purposes but at some point decided to help others. I will get to it when I have a moment.

On Tue, Jul 24, 2018 at 9:31 AM, Christian Morgan notifications@github.com wrote:

Hi @maykino https://github.com/maykino - I had a very quick look and there may be some gems in here, but you need to rebase your work to the current master before I can review and accept it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/caponica/AmazonMwsComplete/pull/31#issuecomment-407469505, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPBWnQMI7gtxUWSRLd0QqIIJCZ0JZZAks5uJ0vRgaJpZM4VW3a1 .

caponica commented 4 years ago

I'm going to have to close this because it's too far behind master.

If you can rebase it then you're welcome to resubmit.