Closed ghost closed 7 years ago
ACK, lets stick with the following "...to refer to the project as "COAL" and the Python package as pycoal"
Sure thing, apologies for the inconsistent usage. Assigning to self to make the changes which can be merged in a future revision. This will include changes to the image metadata.
We will probably want to follow this convention in future git tags as well:
$ git tag -l | xargs git show --format=oneline --no-patch | grep -ie "^\w*coal"
PyCOAL 0.1
PyCOAL 0.2.0
PyCOAL 0.5.0
PyCOAL 0.5.1
More concise list of the affected files:
$ grep -lis 'pycoal' *
README.md
setup.py
$ grep -Rils 'pycoal' docs/source/* | grep -vi _build
docs/source/conf.py
docs/source/environment.rst
docs/source/index.rst
docs/source/introduction.rst
docs/source/mineral.rst
docs/source/mining.rst
docs/source/quickstart.rst
$ grep -Rils 'pycoal' pycoal/ | grep -v ^Binary | grep -v "pyc$"
pycoal/mining.py
pycoal/tests/mining_test.py
pycoal/tests/test.py
pycoal/tests/images/ang20150422t163638_corr_v1e_img_987_654_rgb.hdr
pycoal/tests/images/ang20150420t182050_corr_v1e_img_class_mining_cut_NHDFlowline_corr.hdr
pycoal/tests/images/ang20150420t182050_corr_v1e_img_class_mining_cut_NHDFlowline_corr.img.aux.xml
pycoal/tests/images/ang20150422t163638_corr_v1e_img_4000-4010_550-560_class.hdr
pycoal/tests/images/ang20150420t182808_corr_v1e_img_class_mining_4200-4210_70-80.hdr
pycoal/tests/images/ang20150420t182050_corr_v1e_img_class_mining_cut.img.aux.xml
pycoal/tests/images/ang20150420t182808_corr_v1e_img_class_4200-4210_70-80.hdr
pycoal/tests/images/ang20150420t182050_corr_v1e_img_class_mining_cut.hdr
pycoal/tests/images/f080702t01p00r08rdn_c_sc01_ort_img_123_456_rgb.hdr
pycoal/tests/images/ang20140912t192359_corr_v1c_img_2580-2590_540-550_class.hdr
pycoal/tests/images/ang20140912t192359_corr_v1c_img_400-410_10-20_class.hdr
pycoal/tests/images/ang20140912t192359_corr_v1c_img_400-410_10-20_rgb.hdr
pycoal/tests/mineral_test.py
pycoal/tests/environment_test.py
pycoal/mineral.py
pycoal/environment.py
Pull https://github.com/capstone-coal/pycoal/issues/98 addresses the changes to the source. The website did not need to be updated. I also modified the wiki pages including the release instructions which will properly document the tagging in the future.
"COAL" (always all-caps) should now be used consistently to name the project and the library, and pycoal
(lowercase and preferably in code style) should be used only to refer to the Python COAL package and module name.
Merged and closed.
Currently all five variations "COAL", "coal", "PyCOAL", "Pycoal", and "pycoal" are in use in our code and documentation:
And on the website:
This was discussed in a previous issue but not resolved. A decision made was to refer to the project as "COAL" and the Python package as
pycoal
. This issue could either update the code and documentation or consider additional alternatives.Assigning initially to @lewismc to confirm naming conventions and then delegate as necessary.