capsule-corp-ternoa / ternoa-proposals

5 stars 2 forks source link

TIP-101 collection : review comments #3

Closed peshwar9 closed 2 years ago

peshwar9 commented 2 years ago

@Leouarz Great job with the TIP-101 collection specs. I had a few comments/questions:

  1. Collection lifecycle is empty. do you want to specify the various states a collection goes through in its lifecycle?
  2. Add title for' External interfaces'. Interfaces are currently shown under lifecycle.
  3. create_nft is an existing interface in Basic NFT. So, as discussed in yesterday's call (Marko's suggestion) can we separate out the interfaces that already exist from the ones that are new for collections?
  4. In the workflow for adding a limit to collection: What happens if the existing number of nfts in a collection is > the limit specified by user?
  5. Would also suggest to add the constraints for each interface under a separate section Rules/Constraints (rn they are mentioned as comments). This way the rules can be made loud and clear.
Leouarz commented 2 years ago
  1. I don't think it's necessary for collections
  2. Done
  3. Done
  4. The limit cannot be < to the number of NFTs (it will check the limit before adding to the collection. If you try to add a limit after creating the collection, it must be superior to collection current number of NFTs)
  5. There are in the comments and in the constraints subtitle