search

caravagnalab / CNAqc

CNAqc - Copy Number Alteration (CNA) Quality Check package
GNU General Public License v3.0
17 stars 8 forks source link

typo? #20

Closed abcoxyzide closed 1 year ago

abcoxyzide commented 2 years ago

https://github.com/caravagnalab/CNAqc/blob/61fab68ac5a639be4b242d99309a19405d1c15a5/R/peak_detector.R#L101-L110

line 107 should be FALSE instead of TRUE, because you want to keep the max count bin?

caravagn commented 2 years ago

I think so, will check it asap.

Militeee commented 1 year ago

Yea had a look at it, probably a typo, this does not update discarded so all(xy_peaks$discarded) stays TRUE. Fixed thanks for spotting. Pretty degenerate case though, might think about returning an error (or a worning) anyway.