Closed bucko13 closed 3 weeks ago
Latest commit: 56ebc1572e677bb38a98998d85384bba44efd6df
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
caravan-coordinator | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 13, 2024 2:25am |
a couple other functions that needed to be using bitcoinjs-lib v6 for taproot output support. previously this would cause an error in trezor signing if the interaction had a psbt and key details, then the old translatePSBT would result in an output without an address.
In caravan coordinator there should be no change in functionality (i added an upgrade so that it would deploy and reflect the other s2tr changes in the prior PR on this subject), but it can be verified by changing the DirectSignatureImporter to pass a PSBT and keyDetails to the signing interaction. This will cause the TrezorSignMultisigTransaction to hit the code path that calls translatePSBT. With the old translatePSBT from
@caravan/bitcoin
, trezor-connect throws an error.