caravan-bitcoin / caravan

Caravan monorepo
https://caravanmultisig.com
MIT License
59 stars 72 forks source link

feat/docs caravan health privacy #195

Closed AvhiMaz closed 3 weeks ago

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: c2664bd8ce2ef8749287bb2ef3f4dcc31bef9623

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
caravan-coordinator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 6:04am
bucko13 commented 1 month ago

Hi @AvhiMaz. Thanks for the contributions! Could you please split up the commit history of this PR so it only has the relevant code? The title says docs for caravan health but it includes #194 code.

AvhiMaz commented 1 month ago

@bucko13 please. have a look I've made suggested changes, Thank you!

bucko13 commented 3 weeks ago

I'm not really sure what the point of this PR is. It looks like some very basic cleanup and now adding a package that's not even being used yet. If you wanted to experiment with generating documentation that we can build and hopefully host with CI I'd be open to work on that (especially something more at the top monorepo level).

AvhiMaz commented 3 weeks ago

@bucko13 closing the pr, let me focus on other one, will be seeing it, implement it correctly and will raise a pr again. thank you.