Closed mattrosno closed 5 months ago
Name | Link |
---|---|
Latest commit | d2291c32d151d56a899f327f14a98870bfdab6d7 |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/66045f02d2e1cd0008b2bb50 |
Deploy Preview | https://deploy-preview-3854--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 123f0223cc7c4f1b3fa7704c3e48336b09f9e18a |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/662a87dd2b69c2000868696b |
Deploy Preview | https://deploy-preview-3854--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hi @cgirani - I see you've reviewed a few of the recent PRs in this repo. Are you able to review this PR? Please let me know if you have any questions.
Summary
Adds the config file and dependency necessary to start tracking telemetry data via IBM Telemetry for the packages:
carbon-addons-iot-react
The
jsx
config was generated by running the JS config generator in/packages/react
with the command:Change List (commits, features, bugs, etc)
files
Acceptance Test (how to verify the PR)
Please look through package.json config files and ensure all necessary modifications have been made so that the "telemetry.yml" config file is included in the release version of each package.
PLEASE NOTE: In order for IBM Telemetry to start collecting data for this project, a new build must be published including these changes.
Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.